馃嵄 Bento Storybook: Define all BUILD_CONSTANTS
#35560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alanorozco! These files were changed: |
samouri
reviewed
Aug 6, 2021
| @@ -67,14 +67,12 @@ export const timelines = () => { | |||
| const timelineUserId = '3450662892'; | |||
| return ( | |||
| bootstrap="https://3p.ampproject.net/2104170104001/vendor/twitter.js" | |||
There was a problem hiding this comment.
This was being passed in because INTERNAL_RUNTIME_VERSION wasn't previously available.
There was a problem hiding this comment.
Actually... I'm going to remove this separately, since there's a few like this sprinkled around and they may involve other changes.
The build constants are presumably already defined in AMP mode, since the same code path doesn't yield the same errors, so I thought it would be extraneous to include it here. Would you recommend updating it anyway? |
samouri
approved these changes
Aug 6, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get
IS_PROD is not definedand similar - example.