✨ Display the publisher domain beneath the header of page attachments that contain a form element #35581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layed only when the attachment contains a form
…gins from 10px to 20px
|
Hey @gmajoulet, @newmuis! These files were changed: |
|
This PR can be reviewed now. I'm working on the visual diff tests, and I'll submit them in a subsequent PR (or commit them to this PR once they're working, if you'd prefer that) |
|
I just added a couple of visual diff tests that verify the presence of the domain header |
gmajoulet
reviewed
Aug 12, 2021
…domain label. Also, rename getPublisherDomain_ to getPublisherOrigin_
gmajoulet
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a domain label element that is added immediately below the page attachment's header, if the page attachment contains a
formelement.Examples
Light theme example:
Dark theme example:
issue #35569
/cc @ampproject/wg-stories