Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Story interactive] Basic Functionality for Detailed Results Component #35588

Merged
merged 23 commits into from
Aug 10, 2021
Merged

✨ [Story interactive] Basic Functionality for Detailed Results Component #35588

merged 23 commits into from
Aug 10, 2021

Conversation

Brandons42
Copy link
Contributor

Copy of #35465

@Brandons42
Pass selected option data through to component
29cce5b
@Brandons42
Merge branch 'main' of github.com:ampproject/amphtml into main
16d7b2a
@Brandons42
Merge branch 'main' into res-functionality
4636d23
@Brandons42
Add unit tests for detailed results component
698d7bf
@Brandons42
Merge branch 'main' into res-functionality
0882fb6
@Brandons42
Restrict to either quiz or poll
a132e4b
@Brandons42
Merge branch 'main' into res-functionality
62ead4e
@Brandons42
Update from merge
915872e
@Brandons42
Adjust unit tests
37693d4
@Brandons42
Adjustments to logic for trigerring layout
767e6e6
@Brandons42
Merge branch 'main' into res-functionality
59d2046
@Brandons42
Refactor layout and element creation
f4ad873
@Brandons42
Update unit tests
65c58e5
@Brandons42
Make usePercentage into class private variable
730989a
@Brandons42
Minor refactors
b861d2d
@Brandons42
Modify result element type
cf64187
@Brandons42
Add new interactive state entry type
fd5061e
@Brandons42
Merge branch 'main' into res-functionality
4e6666a
@Brandons42
Merge branch 'main' into res-functionality
5ad2716
@Brandons42
Merge branch 'main' into res-functionality
6f09902
@Brandons42
Merge branch 'main' into res-functionality
391600b
@Brandons42
Merge branch 'main' into res-functionality
eeedcb9
@amp-owners-bot amp-owners-bot bot requested a review from newmuis August 10, 2021 14:34
@amp-owners-bot
Copy link

Hey @gmajoulet! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-results-detailed.css
extensions/amp-story-interactive/0.1/amp-story-interactive-results-detailed.js
extensions/amp-story-interactive/0.1/amp-story-interactive-results.js
extensions/amp-story-interactive/0.1/test/helpers.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-results-detailed.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-results.js
extensions/amp-story/1.0/amp-story.css

Hey @mszylkowski! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-results-detailed.css
extensions/amp-story-interactive/0.1/amp-story-interactive-results-detailed.js
extensions/amp-story-interactive/0.1/amp-story-interactive-results.js
extensions/amp-story-interactive/0.1/test/helpers.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-results-detailed.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-results.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.css

@mszylkowski mszylkowski requested review from mszylkowski and processprocess and removed request for newmuis August 10, 2021 14:44
@processprocess processprocess mentioned this pull request Aug 10, 2021
Closed
@mszylkowski mszylkowski merged commit ab5bf0e into ampproject:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess approved these changes

@mszylkowski mszylkowski mszylkowski approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Brandons42 @processprocess @mszylkowski @ampprojectbot