Perform Chrome version check to enable highlighting using text fragments #35633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoferbaxter
approved these changes
Aug 12, 2021
| // `'fragmentDirective' in document = true` which breaks feature detection. | ||
| // Chrome 93 supports the proposal that works across iframes, hence this | ||
| // version check. | ||
| if (platform.isChrome() && platform.getMajorVersion() >= 93) { |
There was a problem hiding this comment.
Can we also include the feature detection? After a bit we can remove the Chromium 93 hard coding and rely solely on feature detection.
| this.ampdoc_.win | ||
| ); | ||
|
|
||
| // Chrome 81 added support for text fragment proposal. However, it is |
There was a problem hiding this comment.
Great comment that explains the scenario well. Thanks!
| } | ||
| ); | ||
|
|
||
| // TODO(dmanek): remove `ifChrome` once other major browsers support text fragments |
There was a problem hiding this comment.
If we retain the feature detection, would we need to run this test against Chromium only?
There was a problem hiding this comment.
Correct. If we were not doing Chrome version detection, this could be removed. I've updated the TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #32139.