馃悰 [Story interactive] Fix Container Rendering Issue for Image Quizzes and Polls #35635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @mszylkowski! These files were changed: |
mszylkowski
reviewed
Aug 12, 2021
| @@ -19,7 +19,7 @@ | |||
| --i-amphtml-interactive-img-option-gap: 1em !important; | |||
| --i-amphtml-interactive-img-transform: scale(0.95) !important; | |||
|
|
|||
| border-radius: 3.75em 3.75em 4.375em 4.375em !important; | |||
| border-radius: 3.75em 3.75em 50% 50% / 3.75em 3.75em 4.375em 4.375em !important; | |||
There was a problem hiding this comment.
Nit: Would it work if it only has one value for horizontal and vertical radii if the bottom ones are larger than the img-option-container (just 3.75em 3.75em 4.5em 4.5em)?
There was a problem hiding this comment.
I thought using this strategy would mess up the prompt section for img quiz/polls with 2 options, but I tested it and it works because there's a small region where the chip is straight along the sides.
I just pushed the changes.
processprocess
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed blue pixels shown in below screenshots that are visible when components are placed on white background
After this PR:
/cc @mszylkowski
/cc @processprocess