Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Amp story] Null check on screen.orientation #35639

Merged
merged 1 commit into from
Aug 12, 2021
Merged

🐛 [Amp story] Null check on screen.orientation #35639

merged 1 commit into from
Aug 12, 2021

Conversation

processprocess
Copy link
Contributor

On iPads, orientation is not defined.
An error is being thrown when trying to access the screen.orientation.lock property.

This PR checks if orientation exists before accessing lock.

Related to the work in #35478

Screen Shot 2021-08-12 at 11 17 58 AM

@processprocess processprocess self-assigned this Aug 12, 2021
@processprocess processprocess added this to In progress in wg-stories Desktop One Panel via automation Aug 12, 2021
@processprocess processprocess added this to In progress in wg-stories Sprint via automation Aug 12, 2021
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.js

@processprocess processprocess changed the title 🐛 [Amp story] Null check on screen.orientation.lock 🐛 [Amp story] Null check on screen.orientation Aug 12, 2021
@processprocess processprocess requested review from mszylkowski and removed request for gmajoulet and newmuis August 12, 2021 15:25
@gmajoulet
Copy link
Contributor

If this totally breaks the experience on impacted devices, let's file a P0 and request a cherry-pick.
Thanks for finding and fixing this!

@processprocess processprocess merged commit 4ed4b92 into ampproject:main Aug 12, 2021
wg-stories Sprint automation moved this from In progress to Done Aug 12, 2021
wg-stories Desktop One Panel automation moved this from In progress to Done Aug 12, 2021
@processprocess processprocess deleted the orientation-lock branch August 12, 2021 16:38
@processprocess processprocess mentioned this pull request Aug 12, 2021
Closed
calebcordry pushed a commit that referenced this pull request Aug 12, 2021
@processprocess @calebcordry
Null check on orientation lock. (#35639)
90e5032 
(cherry picked from commit 4ed4b92)
calebcordry pushed a commit that referenced this pull request Aug 12, 2021
@processprocess @calebcordry
Null check on orientation lock. (#35639)
de1b190 
(cherry picked from commit 4ed4b92)
zoharnyego added a commit to apester-dev/amphtml that referenced this pull request Aug 12, 2021
@zoharnyego
Squashed commit of the following:
5393d3c 
commit b9e41a2
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 16:47:01 2021 -0400

    ♻️ Define helper for hash params and drop barely-used `getMode().log` (ampproject#35628)

    * Add getHashParams helper

    * Add win param

    * Update mode.js to use helper

    * Add tests

    * Update callsites

    * Remove getMode().log uses

    * Remove log from ModeDef type

    * Lint fixes

    * Fix tests

    * Split up isModeDevelopment

commit 0e66e28
Author: Alan Orozco <alanorozco@users.noreply.github.com>
Date:   Thu Aug 12 13:25:34 2021 -0700

    🚮 Remove `<amp-story>` check for `<amp-audio>` actions (ampproject#35643)

    Removes check from `<amp-audio>` that prevents actions when descending from an `<amp-story>` element.

    `<amp-story>` now has an action allowlist, so the check was redundant. The action is still prevented, triggering the message '[Action] "AMP-AUDIO.play" is not allowlisted []'.

commit 6b46842
Author: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Date:   Thu Aug 12 13:19:24 2021 -0700

    Update link to modifications best practices (ampproject#35647)

    * Update link to modifications best practices

    * Update dead links

commit a59d776
Author: Raghu Simha <rsimha@amp.dev>
Date:   Thu Aug 12 14:31:55 2021 -0400

    🏗 Move Edge testing from GH Actions to CircleCI (ampproject#35630)

commit b6476c3
Author: Khoi Doan <khoid@google.com>
Date:   Thu Aug 12 13:47:16 2021 -0400

    ✨ Add bitness to User Agent Client Hint Params in ad requests (ampproject#35612)

    * Add User Agent Client Hint Params to Google Ads.

    * Update the param names.

    * Add timeout for UACH promise (1 second).

    * Use fake timers for timeout test.

    * Lint

    * Add exception for dependency on promise.js.

    * Add bitness field to User Agent Client Hints params

    * Fix merge

    * Fix merge again

    * Lint

commit 87d5d14
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:43:51 2021 -0400

    ♻️  Remove `version` from legacy mode object (ampproject#35624)

    * Remove `version` from legacy mode object

    * Restore version to mode-object for now

    * Remove version entirely

    * Lint fixes

    * Fix transformer test fixtures

    * Fix test

commit 00b8e7e
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Thu Aug 12 10:31:56 2021 -0700

    📖 [Story interactive] Add Documentation for Image Quizzes and Polls (ampproject#35618)

    * Documentation text added

    * Add images and source code

    * Reorganize in alphabetical order

    * Reordering

    * Add additional attributes

    * Fix typo

    * Fix typo

    * Fix typo

    * Update screenshots

    * Add note about image sizes

    * Revise note about image size

commit 9813cea
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:27:55 2021 -0400

    ♻️ #core form, modal, amp-element-helpers ("real" diff in desc) (ampproject#35608)

    * Update src/form code

    * Update src/modal code

    * Update src/video-interface code

    * Move src/{form,modal,amp-element-helpers} -> #core/dom

    * Fix types

    * update dep-check config

    * Remove bad assert

    * Update imports of form,modal,amp-element-helpers

    * Fix rebase error

commit 4ed4b92
Author: Philip Bell <philip.hunter.bell@gmail.com>
Date:   Thu Aug 12 12:38:05 2021 -0400

    Null check on orientation lock. (ampproject#35639)

commit 5ff32ad
Author: Chris Antaki <ChrisAntaki@gmail.com>
Date:   Wed Aug 11 15:12:58 2021 -0700

    SwG Release 0.1.22.179 (ampproject#35629)

commit 2106624
Author: Matias Szylkowski <mszylkowski@google.com>
Date:   Wed Aug 11 17:13:54 2021 -0400

    📖 [Story sidebar] Removed sidebar from docs (ampproject#35616)

    * removed sidebar and bookend docs

    * removed unused import

    * revert test removals

    * Add newline on visual test html

commit d21ecc0
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Wed Aug 11 17:01:02 2021 -0400

    ♻️ #core: error helpers (ampproject#35621)

    * Define core/error helpers

    * Drop createErrorVargs

    * Restore name assignment in Log#error

    * Typechecking/extern

    * Remove unused error_ helper

    * Typo

    * Add @ returns

commit 6404407
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Wed Aug 11 13:33:02 2021 -0700

    ✅ [Story interactive] Rename Example Image Quiz and Poll Stories to Use .amp.html Extension (ampproject#35511)

    * Rename examples to use .amp.html extension

    * Remove confetti from results
@processprocess processprocess mentioned this pull request Aug 13, 2021
Closed
@mszylkowski mszylkowski mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newmuis newmuis newmuis approved these changes

@mszylkowski mszylkowski mszylkowski approved these changes

Assignees

@processprocess processprocess

Labels
P0: Drop Everything PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: stories
Projects
wg-stories Desktop One Panel
Done
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@processprocess @gmajoulet @newmuis @mszylkowski @ampprojectbot