馃彈 Fix CircleCI config check so it works with .git caching
#35646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
Aug 12, 2021
|
This PR is all tested and ready to merge. I'll hold off on merging it until later tonight so it has minimal impact on developers who are actively working during the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: With the introduction of
.gitcaching on CircleCI, the repo initialization job often ends up with an outdated view of themainbranch that is restored from the cache. This can cause our check for config freshness to incorrectly pass when it should fail. (The risk is that PRs will run an incomplete set of tests and go on to breakmainonce merged.)PR Highlights:
initialize_repo.shto actually updatemain. (It was doing a fetch, but wasn't updating the localmainbranch.)Initialize Repositoryjob so failures are detected at the very start, and logs are less confusing.Screenshots: link