Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-plugins typecheck: stringish-literals #35670

Merged
merged 1 commit into from
Aug 13, 2021
Merged

babel-plugins typecheck: stringish-literals #35670

merged 1 commit into from
Aug 13, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Aug 13, 2021

No description provided.

@samouri samouri self-assigned this Aug 13, 2021
@samouri samouri marked this pull request as ready for review August 13, 2021 18:23
@amp-owners-bot
Copy link

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-transform-stringish-literals/index.js
build-system/babel-plugins/log-module-metadata.js
build-system/babel-plugins/static-template-metadata.js

@samouri samouri enabled auto-merge (squash) August 13, 2021 18:36
jridgewell
jridgewell reviewed Aug 13, 2021
View reviewed changes
build-system/babel-plugins/babel-plugin-transform-stringish-literals/index.js
if (left.isTemplateLiteral()) {
if (right.isTemplateLiteral()) {
// When both sides are template literals, bypass `babel.evaluate` since it cannot handle this condition.
joinTemplateLiterals(left, right);
return;
}
left;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
left;

@samouri samouri merged commit f43cfa0 into ampproject:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees

@samouri samouri

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samouri @jridgewell @ampprojectbot