Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨🧪 Added CTA Migration page-outlink experiment #35867

Merged
merged 19 commits into from
Sep 1, 2021
Merged

✨🧪 Added CTA Migration page-outlink experiment #35867

merged 19 commits into from
Sep 1, 2021

Commits on Aug 30, 2021

  1. Added CTA Migration page-outlink experiment, added logic to have it l… 

    …oad during the Promise chain in the layout callback
    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    fe4ceaf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ctaMigPt2

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    f26b406 View commit details
    Browse the repository at this point in the history

  3. fixed some circleCI errors

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    530a8f9 View commit details
    Browse the repository at this point in the history

  4. fixed some nits

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    0bb991d View commit details
    Browse the repository at this point in the history

  5. refactored cta migration and added non-hardcoded values

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d8c9312 View commit details
    Browse the repository at this point in the history

  6. fixed cricleci spacing issues

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c8cc2ee View commit details
    Browse the repository at this point in the history

  7. fixed cricleci spacing issues

    @jshamble
    jshamble committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4dd069e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Added description and re-comtting due to circleCI

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ec0084d View commit details
    Browse the repository at this point in the history

  2. Added description and re-comtting due to circleCI

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    99bcc86 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ctaMigPt2

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    15c8d9c View commit details
    Browse the repository at this point in the history

  4. Fixed more code review nits

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    59d4ebe View commit details
    Browse the repository at this point in the history

  5. Fixed layout callback unit test

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    c4d33df View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ctaMigPt2

    @jshamble
    jshamble committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    0523767 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Merge branch 'main' into ctaMigPt2

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    88f6d01 View commit details
    Browse the repository at this point in the history

  2. Added back in code-breaking refactor

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    31c0add View commit details
    Browse the repository at this point in the history

  3. will open new PR to fix page-attachment prod bug

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ce336f3 View commit details
    Browse the repository at this point in the history

  4. fixed main merge

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    784a78e View commit details
    Browse the repository at this point in the history

  5. renamed the expirement to make it clear it was associated with ads

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    7e0e0a9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ctaMigPt2

    @jshamble
    jshamble committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f52fed9 View commit details
    Browse the repository at this point in the history