Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Use Storybook args (second round) #35930

Merged
merged 5 commits into from
Sep 8, 2021
Merged

♻️ Use Storybook args (second round) #35930

merged 5 commits into from
Sep 8, 2021

Commits on Sep 8, 2021

  1. ♻️ Use Storybook args (second round) 

    # Conflicts:
#	extensions/amp-accordion/1.0/storybook/Basic.js
#	extensions/amp-base-carousel/1.0/storybook/Basic.js
#	extensions/amp-date-countdown/1.0/storybook/Basic.js
#	extensions/amp-embedly-card/1.0/storybook/Basic.js
    @alanorozco
    alanorozco committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    ec282eb View commit details
    Browse the repository at this point in the history

  2. fix override

    @alanorozco
    alanorozco committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    77db078 View commit details
    Browse the repository at this point in the history

  3. address review

    @alanorozco
    alanorozco committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    80fdc07 View commit details
    Browse the repository at this point in the history

  4. Update extensions/amp-base-carousel/1.0/storybook/Basic.js 

    Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
    @alanorozco @caroqliu
    alanorozco and caroqliu committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    9d6dd6f View commit details
    Browse the repository at this point in the history

  5. name, consistency

    @alanorozco
    alanorozco committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    759fe28 View commit details
    Browse the repository at this point in the history