Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make amp-form failure message developer-friendlier #35964

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Make amp-form failure message developer-friendlier #35964

merged 2 commits into from
Sep 8, 2021

Commits on Sep 6, 2021

  1. Make amp-form failure message developer-friendlier 

    This can happen whenever the XHR proxy server returns an error and
doesn't include the HTML to render the submit-failure template (e.g.,
AMP CORS failure, unreacheable proxy). Sever-side rendering of template
is an implementation detail of AMP for Email that developers shouldn't
care about so it makes sense to change this to one that would make more
sense for developers.
    @zhangsu
    zhangsu committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    da39ca6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Merge branch 'main' into amp-form-message

    @zhangsu
    zhangsu committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    f0e83f5 View commit details
    Browse the repository at this point in the history