New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segment #3630
Add segment #3630
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -622,6 +622,37 @@ export const ANALYTICS_CONFIG = { | |||
}, | |||
}, | |||
|
|||
'segment': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We automatically generate a golden file test for this that you will need to update. See https://travis-ci.org/ampproject/amphtml/builds/138287933
lgtm. Thanks for adding the support! |
@yields: Have you signed the CLA yet? |
We're just double checking with the lawyer that it's all good, but we should be ready to go shortly! :) |
CLAs look good, thanks! |
@jridgewell signed and re-based! |
Add Segment, closes #3418.