Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment #3630

Merged
merged 1 commit into from Jun 21, 2016
Merged

Add segment #3630

merged 1 commit into from Jun 21, 2016

Conversation

yields
Copy link
Contributor

@yields yields commented Jun 17, 2016

Add Segment, closes #3418.

<amp-analytics type="segment">
<script type="application/json">
  {
    "vars": {
      "writeKey": "<key>",
    }
  }
...

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -622,6 +622,37 @@ export const ANALYTICS_CONFIG = {
},
},

'segment': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We automatically generate a golden file test for this that you will need to update. See https://travis-ci.org/ampproject/amphtml/builds/138287933

@avimehta
Copy link
Contributor

lgtm. Thanks for adding the support!

@jridgewell
Copy link
Contributor

@yields: Have you signed the CLA yet?

@calvinfo
Copy link

We're just double checking with the lawyer that it's all good, but we should be ready to go shortly! :)

@googlebot
Copy link

CLAs look good, thanks!

@yields
Copy link
Contributor Author

yields commented Jun 21, 2016

@jridgewell signed and re-based!

@jridgewell jridgewell merged commit 82a52c8 into ampproject:master Jun 21, 2016
@yields yields deleted the add-segment branch June 28, 2016 11:28
@kzap kzap mentioned this pull request Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent-to-Implement: segment
7 participants