Use a single bound task scorer #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
jridgewell
force-pushed
the
peek-scorer-bind
branch
from
8dadfe6
to
ee45800
Compare
Instead of creating a new scorer every time we perform work. Also avoid the use of `Function#bind`, which I suspect maybe -- *maybe* -- has a JIT issue (ampproject#3519).
jridgewell
force-pushed
the
peek-scorer-bind
branch
from
ee45800
to
9ea966e
Compare
|
Ping @erwinmombay, @cramforce. Did we want to get this into an early canary? |
|
I think it is OK if we just put this into normal canary on Thursday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new scorer every time we perform work. Also avoid
the use of
Function#bind, which I suspect maybe -- maybe -- has a JIT issue (#3519).