Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Switch from google-camelcase to local eslint plugin #36755

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

jridgewell
Copy link
Contributor

This allows us to extend the exceptions and add _Enum as an approved case.

Partial for #36754

@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 4, 2021

Hey @rsimha! These files were changed:

build-system/compile/compile.js

Hey @erwinmombay! These files were changed:

build-system/eslint-rules/camelcase.js

Hey @rcebulko! These files were changed:

build-system/tasks/check-types.js

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/logging.js
extensions/amp-story/1.0/media-pool.js
extensions/amp-story/1.0/pagination-buttons.js

@samouri
Copy link
Member

samouri commented Nov 4, 2021

1. Did you intentionally remove the package-lock.json file? edit: it isn't removed
2. I might be going crazy...but I can't find the camelcase rule in this PR. Did you forget to add the file?

@rsimha
Copy link
Contributor

rsimha commented Nov 4, 2021

1. Did you intentionally remove the package-lock.json file? edit: it isn't removed

The reason package-lock.json looked like it was removed was the large number of lines changed. This is almost certainly due to the use of an older (non-active-lts) version of npm. Best way to fix is to revert package-lock.json, run nvm install --lts, make sure you're on node 16 / npm 8, and re-run npm install.

@jridgewell
Copy link
Contributor Author

  1. Did you intentionally remove the package-lock.json file? edit: it isn't removed

Raghu's answer is correct, I had an old terminal window open that still had node v14. Fixed.

  1. I might be going crazy...but I can't find the camelcase rule in this PR. Did you forget to add the file?

Yup, forgot to commit it. Fixed.

This allows us to extend the exceptions and add `_Enum` as an approved case.

Partial for ampproject#36754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants