AMP SlideScroll Experiment: enable looping. #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelburrito
force-pushed
the
scrollflex-loop
branch
2 times, most recently
from
9ca3854
to
482f0a6
Compare
| position: relative; | ||
| white-space: nowrap; | ||
| position: relative !important; | ||
| text-align: center; |
camelburrito
force-pushed
the
scrollflex-loop
branch
2 times, most recently
from
634328d
to
8c77301
Compare
|
PTAL |
| .-amp-carousel-end-marker { | ||
| background-color: transparent !important; | ||
| display: block !important; | ||
| flex: 1 0 1px !important; |
There was a problem hiding this comment.
it should be 0 0 1px, right?
camelburrito
force-pushed
the
scrollflex-loop
branch
from
be21077
to
82b5362
Compare
| @@ -158,26 +174,32 @@ export class AmpSlideScroll extends BaseCarousel { | |||
| // (which is at scrollLeft 0) when slide 0 is requested - for all other | |||
| // instances we show the second slide (middle slide at | |||
| // scrollLeft = slide's width). | |||
| const newScrollLeft = (newIndex == 0) ? 0 : this.slideWidth_; | |||
| let newScrollLeft = this.slideWidth_; | |||
| if ((!this.hasLooping_ && newIndex == 0) || noOfSlides_ == 1) { | |||
There was a problem hiding this comment.
Another formula here, if you'd like it better:
if (showIndexArr[0] == newIndex) {
newScrollLeft = 0;
}
There was a problem hiding this comment.
Again taken care by setting hasLooping = false where there is only one slide.
camelburrito
force-pushed
the
scrollflex-loop
branch
from
6ca1437
to
92fe8a5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Yet to come
Part 4 for - #3465