Lint remaining static enums in src #36821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay! These files were changed: Hey @alanorozco! These files were changed: Hey @jeffkaufman! These files were changed: Hey @gmajoulet! These files were changed: Hey @processprocess! These files were changed: Hey @t0mg! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
samouri
reviewed
Nov 8, 2021
| @@ -1622,10 +1624,10 @@ export function setConsentStateForTesting(newConsentState) { | |||
| * | |||
| * Copied from src/video-interface.js. | |||
| * | |||
| * @const {!Object<string, string>} | |||
There was a problem hiding this comment.
surprised you found this given it didn't have an enum annotation
| @@ -36,7 +36,9 @@ | |||
| * | |||
| * @return {!Object} | |||
| */ | |||
| module.exports = function (context) { | |||
| // eslint-disable-next-line | |||
| module.exports = function create(context) { | |||
There was a problem hiding this comment.
- Why do you need to disable line for the line?
- Was this PR automatically generated via the fixer for this rule? If yes how did you detect the vardecl had an enum annotation?
There was a problem hiding this comment.
- Eslint requires you to have a
meta: { fixable: 'code' }field if you have a fixer. I didn't feel like changing the full linter to satisfy. -
- Yes
- What about
vardecl?
|
Curious that v0 is down ~0.1kb |
jridgewell
force-pushed
the
static-enum-1
branch
2 times, most recently
from
763785c
to
352367f
Compare
jridgewell
force-pushed
the
static-enum-1
branch
4 times, most recently
from
43e0129
to
efbdc7d
Compare
It requires its own PR.
jridgewell
force-pushed
the
static-enum-1
branch
from
efbdc7d
to
f6e5bcb
Compare
samouri
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These require no refactoring, they're already fully static.
Partial for #36754