Generate a Z_INDEX.md file with z indexes used in the project #3683
Conversation
erwinmombay
force-pushed
the
css-markdown
branch
from
139f48b
to
537a390
Compare
erwinmombay
force-pushed
the
css-markdown
branch
2 times, most recently
from
0523cc0
to
c4de831
Compare
|
@sriramkrish85 PTAL |
erwinmombay
changed the title
erwinmombay
force-pushed
the
css-markdown
branch
from
c4de831
to
5c3ab37
Compare
| @@ -1,99 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
woot, thats embarrassing. meant to reset to master, not revert/delete the file! undone.
erwinmombay
force-pushed
the
css-markdown
branch
from
5c3ab37
to
12081c0
Compare
| rows.push(row); | ||
| }); | ||
| }); | ||
| var tbl = table(rows, tableOptions); |
There was a problem hiding this comment.
could we sort by z-index before pushing?
There was a problem hiding this comment.
yeah, the reason why i didn't do that is its possible to have multiple z-indexes on a single row if for example one declared a z-index in one rule on the same file and then reassigned a new z-index somewhere down the file. (i know its stupid and we probably would catch it in review, but its just possible in css thats all). will sort
erwinmombay
force-pushed
the
css-markdown
branch
from
12081c0
to
b44b7ce
Compare
|
@sriramkrish85 PTAL |
|
@erwinmombay at some point we need to try and add unit tests (at least minimally) or may be golden tests to the tasks to make sure some one accidentally does not break it. |
|
a golden test would be great, but writing unit tests for these aren't worth it IMO. I'll add a golden test. |
erwinmombay
force-pushed
the
css-markdown
branch
3 times, most recently
from
ecbf9b2
to
ff6b685
Compare
| require('./lint'); | ||
| require('./make-golden'); | ||
| require('./presubmit-checks'); | ||
| require('./serve'); | ||
| require('./size'); | ||
| require('./test'); | ||
| require('./runtime-test'); |
There was a problem hiding this comment.
@cramforce fyi, renamed file.
erwinmombay
force-pushed
the
css-markdown
branch
6 times, most recently
from
7fbc7de
to
c42f4f1
Compare
erwinmombay
force-pushed
the
css-markdown
branch
from
c42f4f1
to
4d0554e
Compare
erwinmombay
force-pushed
the
css-markdown
branch
from
4d0554e
to
cba0994
Compare
No description provided.