Implement pull-to-refresh blocker #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko is this testable locally or just in the context of the viewer? |
|
You can test locally if you add "#p2r=0" to the URL. However, keep in mind that hash is removed by AMP, so if you refresh it will be reset. In other words you need to type it every time. |
|
@dvoytenko LGTM |
dvoytenko
added a commit
that referenced
this pull request
Sep 30, 2015
Implement pull-to-refresh blocker
ghost
pushed a commit
that referenced
this pull request
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331.