Add Element Collapse API #3721
Merged
Add Element Collapse API #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
collapse-parents
branch
from
036c684
to
d4fe68e
Compare
| * Collapses the element, and notifies its owner (if there is one) that the | ||
| * element is no longer present. | ||
| */ | ||
| collapse() { |
There was a problem hiding this comment.
Should we restrict access to this method via presubmits?
There was a problem hiding this comment.
Do you mean that it has to be marked /*OK*/ and /*REVIEW*/?
|
PTAL. |
jridgewell
force-pushed
the
collapse-parents
branch
from
ad3446b
to
d827453
Compare
| @@ -100,11 +119,45 @@ class AmpFlyingCarpet extends AMP.BaseElement { | |||
| this.assertPosition(); | |||
| } catch (e) { | |||
| // Collapse the element if the effect is broken by the viewport location. | |||
| toggle(this.element, false); | |||
| this./*REVIEW*/collapse(); | |||
|
LGTM |
jridgewell
force-pushed
the
collapse-parents
branch
from
e27ba4c
to
497a446
Compare
|
@jridgewell Sorry for the delay. This is LGTM |
jridgewell
force-pushed
the
collapse-parents
branch
from
68d432b
to
b5c55e8
Compare
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Fix flying carpet example * Add #collapse and #collapsedCallback * Use #collapse when collapsing AmpElement * Collapse Flying Carpet when all children collapse * Take ownership of the children * Fix imports * Keep track of childNodes, but own children * Tests * #collapse is not a protected API * Collapse a Flying Carpet if only whitespace is visible * OK #collapse * linting * Update presubmit * Update amp-ad * Add more docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
AmpElement#collapseAPI, which hides the element and notifies its owner that it has collapsed. Owner's may react to this by collapsing themselves, for example.Fixes #3338.