✨ Bento amp-gist #37333
Merged
✨ Bento amp-gist #37333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ampproject/wg-caching! These files were changed: |
MichaelRybak
approved these changes
Jan 14, 2022
|
There doesn't appear to be a |
dethstrobe
reviewed
Jan 27, 2022
Comment on lines
+56
to
+64
| <ProxyIframeEmbed | ||
| title={title} | ||
| options={options} | ||
| ref={iframeRef} | ||
| type={TYPE} | ||
| messageHandler={messageHandler} | ||
| style={height ? {...style, height} : style} | ||
| {...rest} | ||
| /> |
There was a problem hiding this comment.
How does this iframe get a src url to load the resource?
I see this must work, since you have it tested.
There was a problem hiding this comment.
As this component is a third-party embed component it generates the src URL from the 3p/github.js based on the gist ID passed to this component as prop
|
@dethstrobe I have updated the README.md for the component. |
dethstrobe
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bento component for `amp-gist.
amp-gistamp-gist