src/preact: use URL instead of parseUrlDeprecated #37561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, how do you generate your bundle size diff? |
jridgewell
requested changes
Feb 3, 2022
jridgewell
approved these changes
Feb 4, 2022
src/preact/component/3p-frame.js
Outdated
| @@ -105,7 +104,7 @@ function ProxyIframeEmbedWithRef( | |||
| }; | |||
| setNameAndSrc({ | |||
| name: JSON.stringify({ | |||
| 'host': parseUrlDeprecated(src).hostname, | |||
| 'host': new URL(src, win.location).hostname, | |||
There was a problem hiding this comment.
Techincally, but does TS not yell at you? The second arg needs to be a string, but location gets coerced to a string so it works in regular JS.
There was a problem hiding this comment.
preact/component/*.js isnt' being typechecked yet. that will happen once this lands: #37463
Will preemptively call .toString() here.
There was a problem hiding this comment.
I think you're looking for .href… 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
We should not use the deprecated path in new code.
This breaks IE11 compat.
bundle size diff
notifications
@ampproject/wg-bento