R1: schedule amp-bind targets #37619
Conversation
samouri
requested review from
jridgewell,
rbeckthomas,
dethstrobe and
alanorozco
| // If amp-bind is trying to mutate an uninitialized BaseElement, it is probably about time | ||
| // to initialize it. | ||
| const scheduler = getSchedulerForDoc(this); | ||
| scheduler.scheduleAsap(this); |
There was a problem hiding this comment.
How's this different than a component setting deferredMount = false when it needs to mutate before mount?
There was a problem hiding this comment.
First, this affects every component instead of only a specific one.
Second, the mount of the component (build/layout) will now be deferred until the amp-bind event occurs instead of on document load. Especially for an initially hidden component it may make sense to defer initialization.
There was a problem hiding this comment.
Would this allow us to remove deferredMount = false from the components that define it?
There was a problem hiding this comment.
The only component that does so is amp-sidebar. Answer is maybe. Unsure right now why deferredMount=false was added to begin with.
summary
Schedules an element to be laid out if it is the target of an amp-bind mutation.
Fixes #37400