🏗 build and copy story localization strings to dist on amp build and amp dist
#37623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`amp dist` We need to start deploying these json files on the Google AMP cache as we will soon lazy load amp-story strings to reduce the size of the story JavaScript binaries.
erwinmombay
force-pushed
the
story-strings
branch
from
43a1597
to
98da7c9
Compare
|
Maybe it's worth clearing this out: is it worth "merging the fallbacks" in this step or in the cache + local server? I have a feeling that it might be easier to do here since it's just one place, but you probably know better. |
erwinmombay
force-pushed
the
story-strings
branch
from
98da7c9
to
fd00269
Compare
|
@mszylkowski yes, probably here. let me push an update |
erwinmombay
force-pushed
the
story-strings
branch
from
118dfbf
to
075bbbc
Compare
danielrozenberg
approved these changes
Feb 9, 2022
Co-authored-by: Daniel Rozenberg <me@danielrozenberg.com>
Co-authored-by: Daniel Rozenberg <me@danielrozenberg.com>
jridgewell
approved these changes
Feb 9, 2022
|
@danielrozenberg could you take another look. added |
mszylkowski
approved these changes
Feb 9, 2022
👍 |
|
Hey @jridgewell! These files were changed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to start deploying these json files on the Google AMP cache as we will soon lazy load amp-story strings to reduce the size of the story JavaScript binaries.