Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @nocollapse annotation which was closure-specific. #37630

Merged
merged 3 commits into from Feb 10, 2022

Conversation

samouri
Copy link
Member

@samouri samouri commented Feb 10, 2022

summary
The @nocollapse property allows for exporting mutable props, but is a Closure-specific annotation.

We no longer need this annotation now that we don't use Closure.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 10, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-debug.js
extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-player/0.1/amp-story-player.js
extensions/amp-story/1.0/amp-story-grid-layer.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story.js

Hey @mszylkowski! These files were changed:

extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-debug.js
extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js

Hey @newmuis! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-player/0.1/amp-story-player.js
extensions/amp-story/1.0/amp-story-grid-layer.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story.js

Hey @alanorozco! These files were changed:

extensions/amp-story-player/0.1/amp-story-player.js

@samouri samouri self-assigned this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants