Progress toward running the Node.js API on ancient versions of Node.js. #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rusty. I have verified that index.js runs OK with that. In index_test.js, fix an es6 construct to be old-style. But even with that it won't pass with 0.10.25. There's one remaining problem with running on Trusty: The shebang line wants node, but on Trusty it's 'nodejs'. I will attempt to fix this in a later revision.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the Node.js version to 0.10.25, the Node.js version from Ubuntu Trusty.
I have verified that index.js runs OK with that.
In index_test.js, fix an es6 construct to be old-style. But even with that
it won't pass with 0.10.25.
There's one remaining problem with running on Trusty: The shebang line
wants node, but on Trusty it's 'nodejs'. I will attempt to fix this in a
later revision.