🐛 Insert empty newline as first line of minified outputs #37640
Conversation
|
Hey @rsimha! These files were changed: |
Was this a recent change? |
| path: original.path, | ||
| text, | ||
| get contents() { | ||
| // eslint-disable-next-line local/no-forbidden-terms |
There was a problem hiding this comment.
Nit: add this as an exception in build-system/test-configs/forbidden-terms.js instead of an explicit eslint-disable here?
I don't know why I didn't do this originally, it's sooo much simpler. This has babel output an inline sourcemap, which is fed into esbuild. Esbuild will do an initial sourcemap-aware bundling, and output a new map that correctly points through babel into our real source files.
jridgewell
force-pushed
the
prepend-sourcemaps
branch
from
0495907
to
fcb166b
Compare
Damn. I changed this back to using |
jridgewell
changed the title
Where does this happen? In AMP Cache? In that case, there is no way around the semicolon hack |
|
The unversioned JS content transformer. |
| return {contents: transformed.code}; | ||
| } | ||
| ); | ||
|
|
||
| build.onEnd(async (result) => { |
There was a problem hiding this comment.
FMI: can you explain this refactor to onEnd?
There was a problem hiding this comment.
In 8c829df, I changed Babel to output an inline sourcemap for esbuild to ingest, thinking it would remap correctly. But esbuild doesn't carry through names (which is why we switched to the complicated remapping + babelMaps in the first place). I'm correcting it this time, but I'm making the code local to the esbuild-babel plugin instead of spreading it across the plugin and consumer. Now the consumer just gets the correctly remapped sourcemaps.
| // We naively prepend content on the first line of during dists and | ||
| // serving (for AMP_CONFIG and AMP_EXP). In order for these to not affect | ||
| // the sourcemap, we must ensure there is no other content on the first | ||
| // line. If you remove this you will annoy Justin. Don't do it. |
There was a problem hiding this comment.
This was for you. 😜
Co-authored-by: Jake Fried <samouri@users.noreply.github.com>
Our sourcemaps got borked again by prepending code without updating the sourcemaps. To make this easy for both
AMP_CONFIGandAMP_EXP, we're putting the;\nback at the beginning of every file. Basically a revert of #36008. revert revert revert revert…