replace some props on the object returned by getMode during compile time #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
remove-islocaldev-closure
branch
5 times, most recently
from
2300d2c
to
7d71ddd
Compare
| @@ -107,8 +107,7 @@ function reportErrorToServer(message, filename, line, col, error) { | |||
| if (this && this.document) { | |||
| makeBodyVisible(this.document); | |||
| } | |||
| const mode = getMode(); | |||
There was a problem hiding this comment.
@cramforce PTAL. works but unfortunately I don't detect re-aliasing right now, is there a way to get the type information of a return type? (I'm sure there is I just don't know how to get to it)
erwinmombay
changed the title
…le time getMode().localDev == false getMode().test == false getMode().minified == true
erwinmombay
force-pushed
the
remove-islocaldev-closure
branch
from
7d71ddd
to
8382726
Compare
| * example: | ||
| * isFunctionInvokeAndPropAccess(n, "getMode", "test"); // matches `getMode().test` | ||
| * | ||
| * @param n |
|
Looks great. Lets add a presubmit check or compile error for |
|
@cramforce will do |
erwinmombay
force-pushed
the
remove-islocaldev-closure
branch
2 times, most recently
from
478b98a
to
d4e8934
Compare
|
@cramforce ready for review again. PTAL |
|
LGTM |
erwinmombay
force-pushed
the
remove-islocaldev-closure
branch
from
d4e8934
to
23181c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMode().localDev == false
getMode().test == false
getMode().minified == true