Disable option to activate autoplay with YT. #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While autoplay is landing in mobile browsers (for now it is still blocked in Safari and Chrome), we deactivate this for now to ensure the experience if good when it becomes available. Autoplay support will be added back later this year with support for features like - no autoplay off screen - mute by default - only autoplay a single video per page
|
I put data-param-autoplay as an example in the doc and examples. |
|
@muxin Good point! Done. |
| expect(iframe.src).to.contain('myParam=hello%20world'); | ||
| // autoplay is temporarily black listed. | ||
| expect(iframe.src).to.not.contain('autoplay=1'); |
There was a problem hiding this comment.
I'm testing that it gets removed.
There was a problem hiding this comment.
The test is failing because of re-calculating the params - as I mentioned in a comment above.
| if ('autoplay' in params) { | ||
| delete params['autoplay']; | ||
| user.warn('Autoplay is currently not support with amp-youtube.'); | ||
| } | ||
| src = addParamsToUrl(src, getDataParamsFromAttributes(this.element)); |
There was a problem hiding this comment.
This actually doesn't use the params const above and it recalculates the params. Please fix.
Also documents the change.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While autoplay is landing in mobile browsers (for now it is still blocked in Safari and Chrome), we deactivate this for now to ensure the experience if good when it becomes available. Autoplay support will be added back later this year with support for features like