Amp slidescroll experiment - Handling Native Snapping #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.noOfSlides_ = this.slides_.length; | ||
|
|
||
| /** @private @const {boolean} */ | ||
| this.hasLooping_ = |
There was a problem hiding this comment.
This is already assigned to above.
|
Can I try this on Heroku? |
|
@cramforce - heroku url - https://ampskrish.herokuapp.com/test/manual/amp-slidescroll.amp.html BTW - this only works on Iphone/safari (were snap points work). |
| const currentScrollLeft = this.slidesContainer_./*OK*/scrollLeft; | ||
| if (currentScrollLeft != this.previousScrollLeft_ && | ||
| !this.hasNativeSnapPoints_) { | ||
| // TODO(sriramkrish85)Handle custom scroll here. |
|
LGTM |
camelburrito
force-pushed
the
snapscroll
branch
2 times, most recently
from
d238724
to
4287743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Yet to come
Part 4 for - #3465