Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Story Preview] Enable stories to play when in preview mode #38121

Merged
merged 23 commits into from Apr 27, 2022

Conversation

coreymasanto
Copy link
Contributor

@coreymasanto coreymasanto commented Apr 20, 2022


The layout logic of amp-story is designed to block until the story has reached the visible visibility state. However, the story should also layout and play in the newly introduced preview visibility state.

@coreymasanto coreymasanto marked this pull request as ready for review April 20, 2022 21:28
@amp-owners-bot
Copy link

amp-owners-bot bot commented Apr 20, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

@coreymasanto coreymasanto self-assigned this Apr 20, 2022
src/service/ampdoc-impl.js Outdated Show resolved Hide resolved
extensions/amp-story/1.0/amp-story.js Outdated Show resolved Hide resolved
extensions/amp-video/0.1/amp-video.js Outdated Show resolved Hide resolved
@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants