Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Story Preview] Remove Android poster image from playing videos in preview mode #38291

Merged
merged 9 commits into from
Jul 26, 2022
Merged

🐛 [Story Preview] Remove Android poster image from playing videos in preview mode #38291

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2f19ce9
Move firstLayoutCompleted() logic to onVideoLoaded_()
coreymasanto Jun 13, 2022
094a20f
Remove console logs and the no-op firstLayoutCompleted() override
coreymasanto Jun 13, 2022
61d1899
Update firstLayoutCompleted() calls in test-amp-video to onVideoLoade…
coreymasanto Jun 13, 2022
ee3a41f
Add back firstLayoutCompleted(), solely with its blurry placeholder l…
coreymasanto Jun 13, 2022
7fbaf91
Merge branch 'main' into previewAndroidPoster
coreymasanto Jul 18, 2022
e14e286
Merge branch 'main' into previewAndroidPoster
coreymasanto Jul 19, 2022
01d0926
Merge branch 'main' into previewAndroidPoster
coreymasanto Jul 19, 2022
9e3c3b7
Merge branch 'main' into previewAndroidPoster
coreymasanto Jul 22, 2022
857645c
Merge branch 'main' into previewAndroidPoster
coreymasanto Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/amp-video/0.1/amp-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,7 @@ export class AmpVideo extends AMP.BaseElement {
/** @private */
onVideoLoaded_() {
dispatchCustomEvent(this.element, VideoEvents_Enum.LOAD);
this.removePosterForAndroidBug_();
}

/** @override */
Expand Down Expand Up @@ -983,7 +984,6 @@ export class AmpVideo extends AMP.BaseElement {
if (!this.hideBlurryPlaceholder_()) {
this.togglePlaceholder(false);
}
this.removePosterForAndroidBug_();
}

/**
Expand Down