Refactor updateSize in amp-iframe #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!this.isResizable_) { | ||
| user.warn(TAG_, | ||
| 'ignoring embed-size request because this iframe is not resizable', | ||
| this.element); | ||
| return; | ||
| } | ||
| this.attemptChangeSize(newHeight, newWidth); |
muxin
force-pushed
the
amp-iframe-updatesize
branch
from
fb7c862
to
101fb19
Compare
* Refactor code that responds to embed-size request into updateSize_ function * Only update width and height of amp-iframe if attemptChangeSize successfully * Add error log if embed-size request has no width or height value provided
muxin
force-pushed
the
amp-iframe-updatesize
branch
from
101fb19
to
7a9551a
Compare
|
I've updated the iframe resize manual test, PTAL |
|
This is LGTM from me, but please wait for the assigned reviewers. |
|
LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Refactor updateSize in amp-iframe * Refactor code that responds to embed-size request into updateSize_ function * Only update width and height of amp-iframe if attemptChangeSize successfully * Add error log if embed-size request has no width or height value provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow resizing amp-iframe to below certain threshold #3746