Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] 馃悰 [amp-story-page-attachment] Allow branching within outlinks #38624

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

processprocess
Copy link
Contributor

Approach for fixing #38622

This skips the drawer opening logic if the attachment link includes #page=.
A drawback is that the URL preview drawer doesn't display if linking to a different story with #page= in the URL.

@processprocess processprocess changed the title [DRAFT] 馃悰 [amp-story-page-outlink] Allow branching with story page outlink [DRAFT] 馃悰 [amp-story-page-attachment] Allow branching within outlinks Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant