Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytics sampling bias by introducing a uniform hashing function. #3897

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Fix analytics sampling bias by introducing a uniform hashing function. #3897

merged 2 commits into from
Jul 7, 2016

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Jul 2, 2016

Fixes #3886

@lannka
Add comments. Reverse loop unit array so it'll be backward compatible…
c8315c2 
… if we ever want to increase precision by using more uints.
@jridgewell
Copy link
Contributor

LGTM.

@lannka lannka merged commit 9e72dc9 into ampproject:master Jul 7, 2016
@lannka lannka deleted the sampling_bias branch July 7, 2016 04:22
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
@lannka @ariangibson
Fix analytics sampling bias by introducing a uniform hashing function. (
11f30b7 
ampproject#3897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jridgewell jridgewell

@avimehta avimehta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lannka @jridgewell @avimehta