Delete framerate service. #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cramforce LGTM |
The numbers are bad (me measure during too many uninteresting times, so everything skews to 60fps) and calling rAF without need blocks out requestIdleCallback. When the frame timing API lands in Chrome we'll be able to gather high quality metrics for the things we actually want to know here.
cramforce
force-pushed
the
delete-framerate
branch
from
5d8bec1
to
0748930
Compare
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
The numbers are bad (me measure during too many uninteresting times, so everything skews to 60fps) and calling rAF without need blocks out requestIdleCallback. When the frame timing API lands in Chrome we'll be able to gather high quality metrics for the things we actually want to know here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numbers are bad (me measure during too many uninteresting times, so everything skews to 60fps) and calling rAF without need blocks out requestIdleCallback. When the frame timing API lands in Chrome we'll be able to gather high quality metrics for the things we actually want to know here.