Set inViewport before scheduling layout #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ampproject#3911. Now the scrolled-into-view `<amp-instagram>` will be scheduled to layout in the first pass after scrolling into view (~10ms, which is just execution time, no idle waiting).
|
LGTM Lets merge, but would be good to add a test. |
|
LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
Fixes ampproject#3911. Now the scrolled-into-view `<amp-instagram>` will be scheduled to layout in the first pass after scrolling into view (~10ms, which is just execution time, no idle waiting).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3911.
Now the scrolled-into-view
<amp-instagram>will be scheduled to layout in the first pass after scrolling into view (~10ms, which is just execution time, no idle waiting).