Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amp slidescroll experiment - Animate navigation buttons #3965

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Amp slidescroll experiment - Animate navigation buttons #3965

merged 2 commits into from
Jul 8, 2016

Conversation

camelburrito
Copy link
Contributor

@camelburrito camelburrito commented Jul 8, 2016 •
edited

In this PR

  • Animate prev and next button scrolling

Yet to come

  • detect scroll end when touchend is available and use timeout as a backup (this should fix IOS elasticity issue 90% of the times)
  • Move autoplay to base template.
  • try tweak the timeout.
  • Hide scrollbars where possible (and yet allow scrolling)

Part 7 for - #3465

@camelburrito camelburrito added this to the Current milestone Jul 8, 2016
dvoytenko
dvoytenko reviewed Jul 8, 2016
View reviewed changes
extensions/amp-carousel/0.1/slidescroll.js
* @return {!Promise}
*/
customSnap_(currentScrollLeft) {
customSnap_(currentScrollLeft, optForceDir) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt_

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dvoytenko
Copy link
Contributor

LGTM with one nit

@camelburrito camelburrito merged commit c11f6cb into ampproject:master Jul 8, 2016
@camelburrito camelburrito deleted the slidescroll_button_anim branch July 8, 2016 18:57
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
@ariangibson
Amp slidescroll experiment - Animate navigation buttons (ampproject#3965
785916e 
)

* Animate Prev and next buttons

* Review fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvoytenko dvoytenko

Labels
None yet
Projects
No open projects
Slidescroll experiment
Completed Pull Requests
Milestone
To be deprecated - Current
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camelburrito @dvoytenko