New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support referrerpolicy
on amp-iframe
#3973
Conversation
LGTM :) |
…framereferrerpolicy
@cramforce Added validator changes. Can you please PTAL and merge? |
@@ -53,6 +53,7 @@ tags: { # <amp-iframe> | |||
attrs: { name: "allowfullscreen" value: "" } | |||
attrs: { name: "allowtransparency" value: "" } | |||
attrs: { name: "frameborder" value_regex: "0|1" } | |||
attrs: { name: "referrerpolicy" value_regex: "no-referrer|origin|unsafe-url" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more possible values. I think we can allow all strings, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Support `referrerpolicy` on `amp-iframe` Closes ampproject#3950
Closes #3950