fix: add missing title in amp-consent iframe element #39940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erwinmombay
approved these changes
Apr 2, 2024
|
@powerivq to give final approval |
powerivq
reviewed
Apr 2, 2024
|
Also can you sign the CLA according to the message above? Thanks |
powerivq
approved these changes
Apr 2, 2024
TribooAnalytics
pushed a commit
to TribooAnalytics/amphtml
that referenced
this pull request
Apr 3, 2024
* fix: add missing title in amp-consent iframe element * fix: improve default title
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* fix: add missing title in amp-consent iframe element * fix: improve default title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic title to internal iframe of the AMP consent component. Following same logic applied in #30834.