Allow passing optional window into getMode #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function getMode() { | ||
| if (mode) { | ||
| return mode; | ||
| export function getMode(opt_win) { |
There was a problem hiding this comment.
Will this have any effect on us being able to DCE this code?
/cc @erwinmombay
|
This is LGTM as soon as @erwinmombay confirms no problems with DCE. |
|
i tested this out, LGTM |
|
Can anyone help me with the type errors? |
|
looking |
| @@ -43,59 +40,57 @@ let fullVersion = ''; | |||
|
|
|||
| /** | |||
| * Provides info about the current app. | |||
| * @param {?Window=} win | |||
There was a problem hiding this comment.
just need to change this into opt_win (the name)
There was a problem hiding this comment.
doing that though seems to make it type check more modules which we haven't fixed yet O_O
There was a problem hiding this comment.
nvm, i ran the command wrong 💨
Instead of some magical private global.
jridgewell
force-pushed
the
mode-opt_win
branch
2 times, most recently
from
5a18922
to
437545c
Compare
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Allow passing optional window into getMode * Cache mode on the window object Instead of some magical private global. * Fix tests * Fix isLocalDev detection * Tests * Linting * Stupid type checking * Fix presubmit error * Fix lingering tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #4037 on @dvoytenko's suggestion.
Allows the
wincontext to be (optionally) passed intogetMode. This important for use in ServiceWorkers since they do not have awindowvariable.