Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefetch method #4062

Merged
merged 1 commit into from Jul 14, 2016
Merged

Conversation

erwinmombay
Copy link
Member

@erwinmombay erwinmombay commented Jul 14, 2016

Fixes #4060

@cramforce
Copy link
Member

Thanks. LGTM

@@ -128,6 +128,16 @@ export class Preconnect {
}

/**
* Temporary to not break prod when versions are misaligned across binaries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a date when this can be safely deleted. And add "DO NOT USE!!!"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. also added presubmit check

@erwinmombay erwinmombay merged commit f0cf55d into ampproject:master Jul 14, 2016
erwinmombay added a commit that referenced this pull request Jul 14, 2016
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants