Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SoundCloud Secret Token #4162

Merged
merged 1 commit into from Jul 22, 2016
Merged

Conversation

jridgewell
Copy link
Contributor

Fixes #3854.

@erwinmombay
Copy link
Member

@jridgewell do you happen to have the link to the documentation for this? having a hell of a time googling for it lol

@erwinmombay
Copy link
Member

@jridgewell LGTM

@jridgewell
Copy link
Contributor Author

o you happen to have the link to the documentation for this? having a hell of a time googling for it lol

You and me both. I figured it out from a combination of http://stackoverflow.com/a/26527881/323767 and @poscar's demo (the iframe's url is https://w.soundcloud.com/player/?url=https%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F252220898%3Fsecret_token%3Ds-CYqsZ).

@jridgewell jridgewell merged commit 966f13d into ampproject:master Jul 22, 2016
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants