Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes: Removed unnecessary Promise.resolve()s #4240

Merged
merged 1 commit into from Jul 28, 2016
Merged

Small fixes: Removed unnecessary Promise.resolve()s #4240

merged 1 commit into from Jul 28, 2016

Conversation

tdrl
Copy link

@tdrl tdrl commented Jul 27, 2016

No description provided.

@jridgewell
Copy link
Contributor

LGTM.

@jridgewell
Copy link
Contributor

@tdrl: You'll probably need to rebase off latest master to get Travis to report.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@tdrl
Copy link
Author

tdrl commented Jul 28, 2016

@jridgewell I rebased off master and pushed, but now it seems to think that every commit from master is a new change on this branch. Clearly, I have something messed up in my git process. :-P Does this break this PR or will it be okay once it merges?

@googlebot
Copy link

CLAs look good, thanks!

@jridgewell
Copy link
Contributor

Did another rebase, just waiting for Travis to report.

@jridgewell jridgewell merged commit 589f817 into ampproject:master Jul 28, 2016
@jridgewell jridgewell deleted the a4a-tdrl-cleanup branch July 28, 2016 19:36
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants