Fix for uncaught attemptChangeSize Error #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I test ads example locally, don't see uncaught errors now |
| @@ -86,7 +86,7 @@ export class AmpList extends AMP.BaseElement { | |||
| const scrollHeight = this.container_./*OK*/scrollHeight; | |||
| const height = this.element./*OK*/offsetHeight; | |||
| if (scrollHeight > height) { | |||
| this.attemptChangeHeight(scrollHeight); | |||
| this.attemptChangeHeight(scrollHeight).then(() => {}, () => {}); | |||
There was a problem hiding this comment.
This just needs a #catch.
|
LGTM. |
| @@ -156,7 +156,7 @@ export class AmpAdApiHandler { | |||
| updateSize_(height, width) { | |||
| const targetOrigin = | |||
| this.iframe_.src ? parseUrl(this.iframe_.src).origin : '*'; | |||
| this.baseInstance_.attemptChangeSize(height, width, () => { | |||
| this.baseInstance_.attemptChangeSize(height, width).then(() => { | |||
There was a problem hiding this comment.
sorry to ask: didn't we have a test to cover this ?
There was a problem hiding this comment.
We have tests for updateSize_ but we only test that attemptChangeSize(height, width) are been called.
You are right we need to test #postMessage is called.
#4256
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.