Improve the integration test for 3P ad networks. #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad networks will fail the test.
| expect(registrations).to.include.key('adition'); | ||
| expect(registrations).to.include.key('adform'); | ||
| // Get all ad extensions from test env. | ||
| const extensions = window.ampTestRuntimeConfig.adExtensions; |
There was a problem hiding this comment.
im honestly slightly conflicted with this, as much as its a nicety i'd rather keep tests as stupid simple as possible even with the repetition.
but yeah, this more positive.
There was a problem hiding this comment.
This test case is to catch any unregistered ad networks. However, if people forgot register the ad network at the first place, he/she will not update this test case as well. So we end up not catching any violation.
|
LGTM, but threw in my 2c |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
…ad networks will fail the test. (ampproject#4260)
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
…ad networks will fail the test. (ampproject#4260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
test-integration.jsis not that helpful regarding to catching an unregistered ad networks. (Because if they didn't register, for sure they'll not update the test as well.)Improved the test by doing:
/ads/dir for all the 3p JS files, then passed to Mocha tests via env variable.This work is part of #4190