Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone AccessServerAdapter for JWT experiment #4262

Merged
merged 1 commit into from Jul 29, 2016

Conversation

dvoytenko
Copy link
Contributor

This is a 100% clone of amp-access-server.js for further experimentation with JWT.

/** @const @private {!AccessTypeAdapterContextDef} */
this.context_ = context;

/** @private @const */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closure infers the ones with constructor.

@erwinmombay
Copy link
Member

@dvoytenko LGTM

@dvoytenko dvoytenko merged commit b082f3a into ampproject:master Jul 29, 2016
@dvoytenko dvoytenko deleted the access71 branch July 29, 2016 00:37
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants