fix latestUpdateTime not getting initialized for live list manager #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
fix-live-list-bug
branch
from
281855a
to
7d32606
Compare
erwinmombay
changed the title
erwinmombay
force-pushed
the
fix-live-list-bug
branch
from
7d32606
to
ecbe320
Compare
erwinmombay
changed the title
|
@lannka PTAL. fixes a bug in live list where the first GET request does not contain the "amp_latest_update_time" parameter on its initial request |
erwinmombay
force-pushed
the
fix-live-list-bug
branch
3 times, most recently
from
0afb6e4
to
8a8647a
Compare
| @@ -137,6 +140,17 @@ describe('LiveListManager', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should get the amp_latest_update_time on doc ready', () => { | |||
There was a problem hiding this comment.
Not sure if it's feasible, but it would be better to test where this private value is used than where it is filled.
In this case, a more robust test would be to check whether the number is finally in the fetch request URL.
|
LGTM with one suggestion on the test. |
erwinmombay
force-pushed
the
fix-live-list-bug
branch
from
8a8647a
to
5f3d030
Compare
|
@lannka this fixes the live-blog sample in your PR. I need to fix the live-list sample next |
erwinmombay
force-pushed
the
fix-live-list-bug
branch
from
5f3d030
to
7ea975a
Compare
|
LGTM |
erwinmombay
force-pushed
the
fix-live-list-bug
branch
from
7ea975a
to
233a7a0
Compare
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.