AMP App Banner #4295
Merged
AMP App Banner #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * limitations under the License. | ||
| */ | ||
|
|
||
| amp-app-banner.experiment-disabled { |
There was a problem hiding this comment.
This has to be -amp-experiment-disabled
|
Addressed comments. PTAL. |
| * limitations under the License. | ||
| */ | ||
|
|
||
| amp-app-banner.-amp-experiment-disabled { |
There was a problem hiding this comment.
Do we still need this class now that we switched to layout=nodisplay?
|
@mkhatib this is close to lgtm. Let's just follow up on a couple of remaining questions. |
|
Addressed comments. PTAL 👀 |
| <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript> | ||
| <script async src="https://cdn.ampproject.org/v0.js"></script> | ||
| <meta name="apple-itunes-app" content="app-id=828256236, app-argument=medium://p/cb7f223fad86"> | ||
| <link rel="amp-manifest" href="manifest.json"> | ||
| <script async src="./viewer-integr.js"></script> |
There was a problem hiding this comment.
One tiny thing here, this script should have the following attribute:
data-amp-report-test="viewer-integr.js"
|
LGTM with a couple more requests. |
mkhatib
force-pushed
the
amp-app-banner-2
branch
from
78ecc52
to
752e759
Compare
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: Open Viewer example here and select the 2nd tab - open on iOS or Android devices on different browsers. (I haven't tested this on Android yet, but will do while this in review).
Another stab at AMP App Banner (earlier PR in which this is largely based on #3447 though refactored). This is following discussions with @ericlindley-g and @cramforce around focusing on the dismissible banner use-case and handle the inline-banner or deep-links later on (possibly with other extensions).
This use the storage API similar to
amp-user-notificationto store a boolean whether this is dismissed or not. @dvoytenko Please advice if this needs a privacy review from someone.I've tried to split the two platforms into two separate classes to avoid a lot of if-else if-else clauses to in every callback, and relied on the new
upgradeCallbackto select the appropriate class based on the platform.ITI: #800