Update <amp-social-share> validation rules to allow within <amp-sidebar> element. #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<amp-sidebar>` element. Add test for the same.
|
LGTM Docs will need to be updated: Specifically: |
|
Good call. I'll mention that on the issue. |
powdercloud
added a commit
that referenced
this pull request
Aug 2, 2016
* Merge validator-full.js and validator-light.js back into validator.js. * Move .js sources into engine subdir. * Avoid @export symbols inside GENERATE_DETAILED_ERRORS conditionals. * Refactoring; no need to have jasmine-2.0-externs. * Rev version number to match #4296 * Fix small problems with error messages. * This file isn't usedful for Github. * Update build.py since the .js sources are now in the engine subdir. * Fix amp-live-list test for updated error message.
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
…ect#4296) `<amp-sidebar>` element. Add test for the same.
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Merge validator-full.js and validator-light.js back into validator.js. * Move .js sources into engine subdir. * Avoid @export symbols inside GENERATE_DETAILED_ERRORS conditionals. * Refactoring; no need to have jasmine-2.0-externs. * Rev version number to match ampproject#4296 * Fix small problems with error messages. * This file isn't usedful for Github. * Update build.py since the .js sources are now in the engine subdir. * Fix amp-live-list test for updated error message.
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Merge validator-full.js and validator-light.js back into validator.js. * Move .js sources into engine subdir. * Avoid @export symbols inside GENERATE_DETAILED_ERRORS conditionals. * Refactoring; no need to have jasmine-2.0-externs. * Rev version number to match ampproject#4296 * Fix small problems with error messages. * This file isn't usedful for Github. * Update build.py since the .js sources are now in the engine subdir. * Fix amp-live-list test for updated error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
<amp-social-share>validation rules to allow within<amp-sidebar>element.Add test for the same.
Addresses #4273