Pass document to onDocumentReady callback #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| whenDocumentReady(this.win.document) | ||
| .then(() => { | ||
| // Two fold. First, resolve the promise to undefined. | ||
| // Second, causes a delay until the promise resolves so that |
There was a problem hiding this comment.
Maybe add a bit more explanation of why this causes a delay. It may look like a no-op to folks not very familiar with how promises work.
|
|
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Pass document to onDocumentReady callback * Update performance-impl.js * Update viewport-impl.js * Update test-document-ready.js * Update amp-form.js
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Pass document to onDocumentReady callback * Update performance-impl.js * Update viewport-impl.js * Update test-document-ready.js * Update amp-form.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to feel productive today. These damn side-effect test failures are driving me crazy.